-
Notifications
You must be signed in to change notification settings - Fork 669
test: adapt functional tests for GitLab 15.8 #2494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nejch If you want to explore the other tests that are failing due to the GitLab version bump feel free. Otherwise I will try to get to it tomorrow after I finish my work day. |
43c70c5
to
eb56aad
Compare
e5db411
to
aa413eb
Compare
@JohnVillalovos I looked at the bulk import failures. It's now disabled by default with 15.8 on the instance and gives a cryptic 404 (filed it upstream: https://gitlab.com/gitlab-org/gitlab/-/issues/391545). I can try to tackle that as I worked on bulk imports. But I havent looked at the user deletion issues yet. This might take a little more work to upgrade. |
@nejch Thanks for investigating. This is probably going to be a weekend project for me. |
Newer versions of GitLab will refuse to create a user with a weak password. In order for us to move to a newer GitLab version in testing use a stronger password for the tests that create a user.
Now GitLab is returning two custom attributes for a user. So don't assert that there are no custom attributes on a new user. [1] https://gitlab.com/gitlab-org/gitlab/-/merge_requests/108250
Switch to newer version of GitLab for testing.
aa413eb
to
6fdaeff
Compare
6fdaeff
to
97e8044
Compare
I believe this was now merged as part of another PR. @JohnVillalovos if you think we missed something please reopen 🙇 (I know some parts are disabled at the moment, but still in the code). |
Agreed! Thanks. |
No description provided.