Skip to content

feat: add support for select="package_file" in package upload #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

JohnVillalovos
Copy link
Member

Add ability to use select="package_file" when uploading a generic package as described in:
https://docs.gitlab.com/ee/user/packages/generic_packages/index.html

Closes: #2557

Changes

Documentation and testing

Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated:

@JohnVillalovos JohnVillalovos requested a review from nejch May 28, 2023 11:18
@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

Merging #2581 (9202cde) into main (8202e3f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9202cde differs from pull request most recent head f829ac8. Consider uploading reports for the commit f829ac8 to get more accurate results

@@           Coverage Diff           @@
##             main    #2581   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files          87       87           
  Lines        5700     5703    +3     
=======================================
+ Hits         5484     5487    +3     
  Misses        216      216           
Flag Coverage Δ
api_func_v4 82.46% <100.00%> (+<0.01%) ⬆️
cli_func_v4 83.06% <100.00%> (-0.05%) ⬇️
unit 87.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gitlab/v4/objects/packages.py 96.49% <100.00%> (+0.19%) ⬆️

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/issue_2557_package_upload branch 4 times, most recently from 27a42e1 to 9202cde Compare May 31, 2023 16:34
Add ability to use `select="package_file"` when uploading a generic
package as described in:
https://docs.gitlab.com/ee/user/packages/generic_packages/index.html

Closes: #2557
@nejch nejch force-pushed the jlvillal/issue_2557_package_upload branch from 9202cde to f829ac8 Compare June 6, 2023 08:20
@nejch nejch merged commit 3a49f09 into main Jun 6, 2023
@nejch nejch deleted the jlvillal/issue_2557_package_upload branch June 6, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload of Generic Package assumes "message" in server's response
2 participants