feat: Allow uploading packages from files and bytes #2633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4f8a948 to
a2beef3
Compare
Codecov Report
@@ Coverage Diff @@
## main #2633 +/- ##
==========================================
+ Coverage 96.35% 96.39% +0.03%
==========================================
Files 87 87
Lines 5656 5662 +6
==========================================
+ Hits 5450 5458 +8
+ Misses 206 204 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
62df3cc to
21855e7
Compare
21855e7 to
7edb1f4
Compare
7edb1f4 to
e8fa2f8
Compare
e8fa2f8 to
34cd932
Compare
34cd932 to
c84874e
Compare
nejch
requested changes
Oct 12, 2023
This commit adds a keyword argument to GenericPackageManager.upload() to allow uploading bytes and file-like objects to the generic package registry. That necessitates changing file path to be a keyword argument as well, which then cascades into a whole slew of checks to not allow passing both and to not allow uploading file-like objects as JSON data. Closes #1815
6951326 to
60553be
Compare
|
Thanks @ernestask and sorry to keep you waiting, I pushed a small commit to fix test names so it's not blocking you any longer. We could probably document this a bit as well, but not urgent. |
|
Memory fails me now, but I did want to write some docs. Something stopped me, though… Probably just wasn’t sure where and what to put. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This commit adds a keyword argument to GenericPackageManager.upload() to allow uploading bytes and file-like objects to the generic package registry. That necessitates changing file path to be a keyword argument as well, which then cascades into a whole slew of checks to not allow passing both and to not allow uploading file-like objects as JSON data.
Closes #1815
Documentation and testing
Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated: