-
Notifications
You must be signed in to change notification settings - Fork 670
feat(api): Add support for new runner creation API #2635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Add support for new runner creation API #2635
Conversation
Not sure if unit tests fits into Please tell me if I should move them. |
b37203c
to
a779089
Compare
Codecov Report
@@ Coverage Diff @@
## main #2635 +/- ##
==========================================
+ Coverage 92.09% 96.36% +4.26%
==========================================
Files 87 87
Lines 5658 5666 +8
==========================================
+ Hits 5211 5460 +249
+ Misses 447 206 -241
Flags with carried forward coverage won't be shown. Click here to find out more.
|
a779089
to
00c3a8d
Compare
In my opinion it should be in the But otherwise this looks good to me. |
00c3a8d
to
c81eb57
Compare
fd02584
to
0236d96
Compare
Hi @JohnVillalovos, and thanks for your feedback ! I moved the unit test into |
0236d96
to
36ae841
Compare
@lgatellier Thanks for the PR! Left comments to have it work like the other endpoints that use |
36ae841
to
16ff385
Compare
16ff385
to
004a51a
Compare
50bc028
to
ad7a58a
Compare
Thanks a lot @lgatellier @JohnVillalovos I just pushed a minor typo suggestion so that we can get this in and continue with the tasks before the next scheduled release. If you see anything else just open a follow-up :) |
Changes
This PR adds support for GitLab's new runner creation API
POST /user/runners
.Closes #2606
Documentation and testing