Skip to content

chore(ci): follow upstream config for release build_command #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2023
Merged

chore(ci): follow upstream config for release build_command #2693

merged 1 commit into from
Oct 17, 2023

Conversation

nejch
Copy link
Member

@nejch nejch commented Oct 17, 2023 •
edited
Loading

I missed that this action runs in a docker container so the earlier install had no effect it seems.

https://github.com/python-semantic-release/python-semantic-release/blob/master/pyproject.toml#L329-L332

There must be a better way than this, but for now this will get us a release 😅

@nejch nejch requested a review from JohnVillalovos October 17, 2023 16:23
@JohnVillalovos JohnVillalovos enabled auto-merge (rebase) October 17, 2023 16:28
@JohnVillalovos JohnVillalovos merged commit 3e20a76 into main Oct 17, 2023
@JohnVillalovos JohnVillalovos deleted the chore/upstream-config branch October 17, 2023 16:35
@nejch nejch mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnVillalovos JohnVillalovos JohnVillalovos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nejch @JohnVillalovos