Skip to content

Conversation

JohnVillalovos
Copy link
Member

Add a warning about using sudo when saving.

Give an example of how to get an object, modify it, and then save it using sudo

Closes: #532

@JohnVillalovos JohnVillalovos requested a review from nejch July 13, 2024 20:13
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/issue_532_sudo branch from b5fb1b8 to c70796f Compare July 15, 2024 06:07
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JohnVillalovos, this should help already even if we don't fully address it (this seems like a more general problem with our approach than the filter issue). Just a few nits 🙇

@JohnVillalovos JohnVillalovos force-pushed the jlvillal/issue_532_sudo branch from c70796f to ae8b093 Compare July 15, 2024 15:05
@JohnVillalovos
Copy link
Member Author

Thanks @JohnVillalovos, this should help already even if we don't fully address it (this seems like a more general problem with our approach than the filter issue). Just a few nits 🙇

Thanks @nejch! I have put your suggestions in place 🙂

@JohnVillalovos JohnVillalovos requested a review from nejch July 15, 2024 15:06
Add a warning about using `sudo` when saving.

Give an example of how to `get` an object, modify it, and then `save`
it using `sudo`

Closes: #532
@JohnVillalovos JohnVillalovos force-pushed the jlvillal/issue_532_sudo branch from ae8b093 to 9fe6b9f Compare July 15, 2024 15:07
@nejch nejch enabled auto-merge (rebase) July 15, 2024 15:23
@nejch nejch merged commit d509da6 into main Jul 15, 2024
16 checks passed
@nejch nejch deleted the jlvillal/issue_532_sudo branch July 15, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sudo should be remembered for SaveMixin objects
2 participants