-
Notifications
You must be signed in to change notification settings - Fork 669
feat(api): support list and delete for group service accounts #2963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): support list and delete for group service accounts #2963
Conversation
@nejch , |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2963 +/- ##
=======================================
Coverage 96.53% 96.53%
=======================================
Files 94 94
Lines 5997 5997
=======================================
Hits 5789 5789
Misses 208 208
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thanks for the contribution @ka28kumar I just got back to this. Yes, this looks good! If you could add a few basic tests/asserts to the existing functional tests, this would be really appreciated! Thanks! |
Will add. Thanks! |
Did you still want to add a few tests here @ka28kumar? Could just be a simple extension of:
E.g.: def test_group_service_accounts(group):
service_account = group.service_accounts.create(
{"name": "gitlab-service-account", "username": "gitlab-service-account"}
)
assert service_account.name == "gitlab-service-account"
assert service_account.username == "gitlab-service-account"
service_accounts = group.service_accounts.list()
assert service_accounts[0] == service_account
service_account.delete() Or something like that. Let me know otherwise we can also take over here! |
I'm sorry I got occupied with some tasks. Feel free to take over. |
Thanks @ka28kumar let's get this merged and I've opened a follow-up for the tests. |
…nd ObjectDeleteMixin to GroupServiceAccount
b57fbf2
to
6605d7a
Compare
add DeleteMixin, ListMixin to GroupServiceAccountManager and ObjectDeleteMixin to GroupServiceAccount
Changes
Documentation and testing
Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated: