Skip to content

feat: remove support for Python 3.8, require 3.9 or higher #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

JohnVillalovos
Copy link
Member

@JohnVillalovos JohnVillalovos commented Oct 1, 2024

Python 3.8 is End-of-Life (EOL) as of 2024-10 as stated in https://devguide.python.org/versions/ and
https://peps.python.org/pep-0569/#lifespan

By dropping support for Python 3.8 and requiring Python 3.9 or higher it allows python-gitlab to take advantage of new features in Python 3.9, which are documented at:
https://docs.python.org/3/whatsnew/3.9.html

Closes: #2968

BREAKING CHANGE: As of python-gitlab 5.0.0, Python 3.8 is no longer supported. Python 3.9 or higher is required.

@nejch
Copy link
Member

nejch commented Oct 2, 2024

Thanks for this @JohnVillalovos. Should we take the opportunity here to add support for some syntax features in 3.9? https://docs.python.org/release/3.9.0/whatsnew/3.9.html. Specifically:

https://peps.python.org/pep-0585/
https://peps.python.org/pep-0584/ (if used at all and where it makes sense)

Maybe also https://peps.python.org/pep-0604/ if we add a future import.

@JohnVillalovos
Copy link
Member Author

Thanks for this @JohnVillalovos. Should we take the opportunity here to add support for some syntax features in 3.9? https://docs.python.org/release/3.9.0/whatsnew/3.9.html. Specifically:

https://peps.python.org/pep-0585/ https://peps.python.org/pep-0584/ (if used at all and where it makes sense)

Maybe also https://peps.python.org/pep-0604/ if we add a future import.

Sure! Once we drop the support for Python 3.8, we can use whatever we want in the future.

@JohnVillalovos
Copy link
Member Author

@nejch Please let me know if there is anything else I should do on this.

Python 3.8 is End-of-Life (EOL) as of 2024-10 as stated in
https://devguide.python.org/versions/ and
https://peps.python.org/pep-0569/#lifespan

By dropping support for Python 3.8 and requiring Python 3.9 or higher
it allows python-gitlab to take advantage of new features in Python
3.9, which are documented at:
https://docs.python.org/3/whatsnew/3.9.html

Closes: #2968

BREAKING CHANGE: As of python-gitlab 5.0.0, Python 3.8 is no longer
supported. Python 3.9 or higher is required.
Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnVillalovos sorry, for some reason I thought we were dependent on the 3.13 release that got postponed, but just realized this only drops support for the old one. I just did another PR earlier today to have a mini release before this breaking change 👍

@nejch nejch merged commit 9734ad4 into main Oct 8, 2024
17 checks passed
@nejch nejch deleted the jlvillal/py38 branch October 8, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2024-10: Remove Python 3.8 as supported Python version
3 participants