Skip to content

fix: raise GitlabHeadError in project.files.head() method #3006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

JohnVillalovos
Copy link
Member

When an error occurs, raise GitlabHeadError in
project.files.head() method.

Closes: #3004

When an error occurs, raise `GitlabHeadError` in
`project.files.head()` method.

Closes: #3004
@JohnVillalovos JohnVillalovos requested a review from nejch October 1, 2024 15:31
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (2ab0b9f) to head (6494630).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3006   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files          95       95           
  Lines        6088     6089    +1     
=======================================
+ Hits         5882     5883    +1     
  Misses        206      206           
Flag Coverage Δ
api_func_v4 82.64% <100.00%> (+<0.01%) ⬆️
cli_func_v4 82.90% <100.00%> (+<0.01%) ⬆️
unit 88.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
gitlab/v4/objects/files.py 100.00% <100.00%> (ø)

Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JohnVillalovos 🙇 didn't even think this would be an issue

@nejch nejch merged commit 9bf26df into main Oct 1, 2024
18 checks passed
@nejch nejch deleted the jlvillal/issue_3004_gitlabheadexception branch October 1, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correctly raise GitlabHeadError in head method
2 participants