Make repr() of project approval rules consistent with merge request approval rules #3011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3011 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 95 95
Lines 6100 6101 +1
=======================================
+ Hits 5894 5895 +1
Misses 206 206
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
reviewed
Oct 10, 2024
There was a problem hiding this comment.
Thanks a lot @holysoles looks great! Just a quick question.
nejch
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The representation attribute for
ProjectMergeRequestApprovalRuleisname(see here), which makes sense based on the API documentation. However, the API forProjectApprovalRuleis nearly the same, but we don't set the representation attribute tonamefor that class (see here).This MR sets
_repr_attrfor theProjectApprovalRuleclass , as well as adds a unit test for ensure we can list a project's approval rules, and callrepr()on it.Documentation and testing
Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated: