feat(api): added support for tls client authentication against revers… #3111
Conversation
de48308 to
9b06c68
Compare
9b06c68 to
b0e9374
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3111 +/- ##
==========================================
- Coverage 97.28% 97.26% -0.03%
==========================================
Files 97 97
Lines 6006 6028 +22
==========================================
+ Hits 5843 5863 +20
- Misses 163 165 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Thanks a lot for this contribution @mgrechukh!
Normally I'd say this is a perfect use for a custom session - but for the CLI, we'd really need this.
Would you be able to add a small test with a matcher to ensure the cert is passed?
https://github.com/getsentry/responses?tab=readme-ov-file#request-keyword-arguments-matcher
We should have examples from before in our tests for similar mocks, but let me know if it gets too difficult.
I'm also still thinking about the exact interface here. requests can take a tuple but also just a string to a combined cert file. httpx for example would only take the entire cert chain https://www.python-httpx.org/advanced/ssl/#client-side-certificates and not a tuple.
Certain reverse proxies may require TLS client pre-authentication in addition to further API authentication on application level. To facilitate CLI work in such environment, relevant config options added.