Skip to content

chore(ci): replace docs artifact with readthedocs previews #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

nejch
Copy link
Member

@nejch nejch commented Feb 7, 2025

Closes #1445

Changes

Enabled https://docs.readthedocs.com/platform/stable/guides/pull-requests.html
Keeps the actual docs build in CI just in case.

Documentation and testing

Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated:

@nejch
Copy link
Member Author

nejch commented Feb 7, 2025

E.g. https://python-gitlab--3127.org.readthedocs.build/en/3127/ from the PR checks widget:

image

Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This looks great.

@JohnVillalovos JohnVillalovos merged commit 193c5de into main Feb 8, 2025
19 checks passed
@JohnVillalovos JohnVillalovos deleted the chore/rtd-pr branch February 8, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI test to mimic Read The Docs build
2 participants