Skip to content

Add support for project tag list filters #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nsandlin1
Copy link

Added _list_filters attribute to gitlab.v4.objects.tags.ProjectTagManager to support defined api list filters: order_by, sort and search.

Closes #3156

@nsandlin1 nsandlin1 changed the title feat(api): add support for project tag list filters Add support for project tag list filters Mar 23, 2025
Copy link

codecov bot commented Mar 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (bfd31a8) to head (7b8813a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3157   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files          98       98           
  Lines        6056     6057    +1     
=======================================
+ Hits         5894     5895    +1     
  Misses        162      162           
Flag Coverage Δ
api_func_v4 83.73% <100.00%> (+0.11%) ⬆️
cli_func_v4 84.69% <100.00%> (+<0.01%) ⬆️
unit 90.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
gitlab/v4/objects/tags.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JohnVillalovos JohnVillalovos force-pushed the feature/missing-list-filters-on-projecttagmanager branch from 2e4c9a3 to f00c53c Compare April 17, 2025 16:28
@JohnVillalovos JohnVillalovos force-pushed the feature/missing-list-filters-on-projecttagmanager branch from f00c53c to 7b8813a Compare June 7, 2025 14:45
@JohnVillalovos JohnVillalovos requested a review from Copilot June 7, 2025 14:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for API list filters (order_by, sort, search) in the ProjectTagManager to allow filtering when listing project tags.

  • Introduced the _list_filters attribute to ProjectTagManager
Comments suppressed due to low confidence (2)

gitlab/v4/objects/tags.py:22

  • Add tests to verify that the order_by, sort, and search filters work correctly when listing project tags via ProjectTagManager.list().
_list_filters = ("order_by", "sort", "search")

gitlab/v4/objects/tags.py:22

  • Update the docstring for ProjectTagManager.list() (or relevant user guide) to mention support for the order_by, sort, and search list filters.
_list_filters = ("order_by", "sort", "search")

Copy link
Member

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @nsandlin1

@JohnVillalovos JohnVillalovos enabled auto-merge (rebase) June 7, 2025 14:47
@JohnVillalovos JohnVillalovos merged commit 378a836 into python-gitlab:main Jun 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing list filters on ProjectTagManager
2 participants