feat(api): add iteration_id as boards create attribute #3191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,7 +23,7 @@ class GroupBoardListManager(CRUDMixin[GroupBoardList]): | |||
| _obj_cls = GroupBoardList | |||
| _from_parent_attrs = {"group_id": "group_id", "board_id": "id"} | |||
| _create_attrs = RequiredOptional( | |||
| exclusive=("label_id", "assignee_id", "milestone_id") | |||
| exclusive=("label_id", "assignee_id", "milestone_id", "iteration_id") | |||
There was a problem hiding this comment.
According to the docs I don't see that iteration_id is mutually exclusive. Can you confirm? Though for group they don't mention that any of them are mutually exclusive but project does.
https://docs.gitlab.com/api/group_boards/#new-group-issue-board-list
There was a problem hiding this comment.
I made a test using a simple curl:
But you are right I don't see any docs about this.
| @@ -48,7 +48,7 @@ class ProjectBoardListManager(CRUDMixin[ProjectBoardList]): | |||
| _obj_cls = ProjectBoardList | |||
| _from_parent_attrs = {"project_id": "project_id", "board_id": "id"} | |||
| _create_attrs = RequiredOptional( | |||
| exclusive=("label_id", "assignee_id", "milestone_id") | |||
| exclusive=("label_id", "assignee_id", "milestone_id", "iteration_id") | |||
There was a problem hiding this comment.
According to the docs I don't see that iteration_id is mutually exclusive. Can you confirm?
|
Thanks @massimiliano96 |
|
Happy to contribute! @JohnVillalovos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added support for iteration_id as an attribute when creating board lists.