refactor "_sanitize" for Python < 2.7 #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpocentek
pushed a commit
that referenced
this pull request
Sep 6, 2014
refactor "_sanitize" for Python < 2.7
|
Looks good, thanks! |
|
Hi I found some issues with python2.66 (I am stuck with Red Hat 6) . File gitlab/v3/objects.py line 2094 and 2095 (https://github.com/python-gitlab/python-gitlab/blob/master/gitlab/v3/objects.py#L2094) And file gitlab/base.py line 524 https://github.com/python-gitlab/python-gitlab/blob/master/gitlab/base.py#L524 I am not familiar with the pull request full or even github itself so I am not very sure how to proceed. Should I create a pull request ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a python2.6 project which I'd like to use this on, so it does not handle dictionary comprehensions. I believe this patch would make it compatible for Python 2.6+.