add "list pipeline jobs" handler #378
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as described here: https://docs.gitlab.com/ee/api/jobs.html#list-pipeline-jobs example: `jobs = pipeline.jobs.list()`
c4b595b to
2848455
Compare
gpocentek
reviewed
Dec 11, 2017
| @@ -1764,6 +1768,12 @@ def create(self, data, **kwargs): | |||
| return CreateMixin.create(self, data, path=path, **kwargs) | |||
|
|
|||
|
|
|||
| class PipelineJobManager(ListMixin, RESTManager): | |||
There was a problem hiding this comment.
Since you can list and get jobs, you should use a RetrieveMixin here.
| @@ -1764,6 +1768,12 @@ def create(self, data, **kwargs): | |||
| return CreateMixin.create(self, data, path=path, **kwargs) | |||
|
|
|||
|
|
|||
| class PipelineJobManager(ListMixin, RESTManager): | |||
| _path = '/projects/%(project_id)s/pipelines/%(pipeline_id)s/jobs' | |||
| _obj_cls = ProjectJob | |||
There was a problem hiding this comment.
Although this seems to be a good idea to use a ProjectJob, things get a bit more complicated than expected when using the CLI. To avoid bad surprises I try to stick to the upstream API logic: we are requesting a different URL so we get a different object class.
Could you create and use a PipelineJob object class instead?
|
i was just going to create a pull request for such handler, and it is very useful as well. Thanks to @akaWolf and @gpocentek |
|
I'm closing this MR since there's been no update, and #413 implements the feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as described here:
https://docs.gitlab.com/ee/api/jobs.html#list-pipeline-jobs
example:
jobs = pipeline.jobs.list()