Skip to content

mixins.py: Avoid sending empty update data to issue.save #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2017
Merged

mixins.py: Avoid sending empty update data to issue.save #389

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c010b2
mixins.py: Avoid sending empty update data to issue.save
csoriano1618 Dec 6, 2017
13f1a35
Fix two typos
csoriano1618 Dec 11, 2017
4047536
Update code to be more pythonic
csoriano1618 Dec 13, 2017
130a7c1
Use updated data, not need to query the keys
csoriano1618 Dec 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions gitlab/mixins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,9 @@ def save(self, **kwargs):
GitlabUpdateError: If the server cannot perform the request
"""
updated_data = self._get_updated_data()
# Nothing to update. Server fails if sent an empty dict.
if not updated_data:
return

# call the manager
obj_id = self.get_id()
Expand Down