Skip to content

Python3 compatibility #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2014
Merged

Python3 compatibility #40

merged 3 commits into from
Oct 24, 2014

Conversation

mjmaenpaa
Copy link
Contributor

Python 3 does not have unicode type.
Added future import for print_function so that print is handled same in both 2 and 3.
Added future imports for division and absolute import for future compatiblity even though they are not currently needed.

@mjmaenpaa
Copy link
Contributor Author

Using six would be fine. Initially I didn't want to add a new dependency to six, because there was only few places that needed updates. I can update pull request tomorrow with a version that uses six.

@gpocentek
Copy link
Contributor

I don't mind adding a dependency on six. An update would be nice. Thanks for your work!

@mjmaenpaa
Copy link
Contributor Author

I updated with new version that uses six. I did not change dictionary iteration with .items() to use six, because it is mostly used to iterate over dictionary. In two places where dictionary is modified during iteration, I added explicit conversion to list.

gpocentek pushed a commit that referenced this pull request Oct 24, 2014
Python3 compatibility
@gpocentek gpocentek merged commit 1eccc3b into python-gitlab:master Oct 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants