Skip to content

Simplify the example for streamed artifacts #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

tardyp
Copy link
Contributor

@tardyp tardyp commented Jan 29, 2018

Going through an object adds a lot of complication.
Adding example for unzipping on the fly

@tardyp tardyp closed this Jan 29, 2018
@tardyp tardyp reopened this Jan 29, 2018
@tardyp
Copy link
Contributor Author

tardyp commented Jan 29, 2018

restarting ci

@gpocentek
Copy link
Contributor

Thanks again @tardyp :)

Your example is clearly simpler, but I'd rather keep the class-based example as well, as a way to illustrate a bit more complex setups. Could you update your patch?

Going through an object adds a lot of complication.
Adding example for unzipping on the fly
@tardyp
Copy link
Contributor Author

tardyp commented Feb 5, 2018

@gpocentek here you go

@gpocentek
Copy link
Contributor

@tardyp Thanks for the fast update! I'll let the CI do its job then merge.

@gpocentek gpocentek merged commit 6ea7ab7 into python-gitlab:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants