add group members all #599
Conversation
|
@hans-d Thanks for your contribution! Could you please also add some tests and add this endpoint to the documentation? Thanks 😃 |
| pass | ||
|
|
||
|
|
||
| class GroupMemberAllManager(ListMixin, RESTManager): |
There was a problem hiding this comment.
I understand your goal here, but I think it would make more sense to add an all() method to the GroupMemberManager class. The RunnerManager class has the same logic. From a REST point of view all is an action applied to the resource at path /groups/:id:/members (GroupMember).
Does that make sense?
There was a problem hiding this comment.
Makes sense, hadn't seen that variation yet. Will try to change it like that soonish
|
Hi @hans-d Is it OK with you if I take over this MR? Thanks |
|
Fine by me |
|
This should probably be implemented in the same way for project members... |
|
I pushed #642 which will add support for the method for groups and projects. Closing this one. |
fixes #589:
gitlab group-member-all list --group-id $id