fix(docker): use docker image with current sources #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile
Outdated
|
|
||
| WORKDIR /opt/python-gitlab | ||
| COPY --from=build /opt/python-gitlab/dist dist/ | ||
| RUN pip install $(find dist -name *.whl) |
There was a problem hiding this comment.
We could also delete the wheel here, and build the docker image with --squash, to save a tiny bit of extra space.
There was a problem hiding this comment.
--squash still seems to be experimental, but otherwise good idea!
Dockerfile
Outdated
| @@ -0,0 +1,15 @@ | |||
| FROM python:alpine AS build | |||
There was a problem hiding this comment.
Should we pin to a Python version?
There was a problem hiding this comment.
Might be better. Maybe 3.8 will break something. I don't think so, but best practice.
README.rst
Outdated
| How to use | ||
| ---------- | ||
|
|
||
| ``docker run -it --rm -e GITLAB_PRIVATE_TOKEN=<your token> =/python-gitlab.cfg python-gitlab <command> ...`` |
There was a problem hiding this comment.
I copied that from contrib/docker/README.rst and just glanced over it. Nice find.
gpocentek
approved these changes
Oct 11, 2018
|
@gpocentek Feel free to merge, if you approve 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #602