Skip to content

refactor: rename MASTER_ACCESS #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/gl_objects/access_requests.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ following constants are provided to represent the access levels:
* ``gitlab.GUEST_ACCESS``: ``10``
* ``gitlab.REPORTER_ACCESS``: ``20``
* ``gitlab.DEVELOPER_ACCESS``: ``30``
* ``gitlab.MASTER_ACCESS``: ``40``
* ``gitlab.MAINTAINER_ACCESS``: ``40``
* ``gitlab.OWNER_ACCESS``: ``50``

References
Expand Down Expand Up @@ -43,7 +43,7 @@ Create an access request::
Approve an access request::

ar.approve() # defaults to DEVELOPER level
ar.approve(access_level=gitlab.MASTER_ACCESS) # explicitly set access level
ar.approve(access_level=gitlab.MAINTAINER_ACCESS) # explicitly set access level

Deny (delete) an access request::

Expand Down
2 changes: 1 addition & 1 deletion docs/gl_objects/groups.rst
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ The following constants define the supported access levels:
* ``gitlab.GUEST_ACCESS = 10``
* ``gitlab.REPORTER_ACCESS = 20``
* ``gitlab.DEVELOPER_ACCESS = 30``
* ``gitlab.MASTER_ACCESS = 40``
* ``gitlab.MAINTAINER_ACCESS = 40``
* ``gitlab.OWNER_ACCESS = 50``

Reference
Expand Down
2 changes: 1 addition & 1 deletion docs/gl_objects/projects.rst
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ Add a project member::

Modify a project member (change the access level)::

member.access_level = gitlab.MASTER_ACCESS
member.access_level = gitlab.MAINTAINER_ACCESS
member.save()

Remove a member from the project team::
Expand Down
2 changes: 1 addition & 1 deletion docs/gl_objects/protected_branches.rst
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Create a protected branch::
p_branch = project.protectedbranches.create({
'name': '*-stable',
'merge_access_level': gitlab.DEVELOPER_ACCESS,
'push_access_level': gitlab.MASTER_ACCESS
'push_access_level': gitlab.MAINTAINER_ACCESS
})

Delete a protected branch::
Expand Down
3 changes: 2 additions & 1 deletion gitlab/const.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
GUEST_ACCESS = 10
REPORTER_ACCESS = 20
DEVELOPER_ACCESS = 30
MASTER_ACCESS = 40
MAINTAINER_ACCESS = 40
MASTER_ACCESS = MAINTAINER_ACCESS
OWNER_ACCESS = 50

VISIBILITY_PRIVATE = 0
Expand Down