Skip to content

fix(api): avoid parameter conflicts with python and gitlab #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2019
Merged

fix(api): avoid parameter conflicts with python and gitlab #681

merged 1 commit into from
Jan 19, 2019

Conversation

gpocentek
Copy link
Contributor

Provide another way to send data to gitlab with a new query_parameters
argument. This parameter can be used to explicitly define the dict of
items to send to the server, so that **kwargs are only used to specify
python-gitlab specific parameters.

Closes #566
Closes #629

max-wittig
max-wittig requested changes Jan 13, 2019
View reviewed changes
Copy link
Member

@max-wittig max-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a difficult conceptual problem to solve and this seems like a good compromise (usability vs. edge cases).

I just noticed the the minor typos, otherwise looks good and works as expected 👍

fix(api): avoid parameter conflicts with python and gitlab
4bd027a 
Provide another way to send data to gitlab with a new `query_parameters`
argument. This parameter can be used to explicitly define the dict of
items to send to the server, so that **kwargs are only used to specify
python-gitlab specific parameters.

Closes #566
Closes #629
@gpocentek
Copy link
Contributor Author

Thanks for the review!

@gpocentek
Copy link
Contributor Author

Typos fixed and checked passed, let me know if this looks OK to you.

@max-wittig
Copy link
Member

Sorry totally forgot about this. Looks good to me. Let's merge it.

@max-wittig max-wittig merged commit 572029c into master Jan 19, 2019
@max-wittig max-wittig deleted the no-param-conflicts branch February 18, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-wittig max-wittig max-wittig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpocentek @max-wittig