Skip to content

Make gitlab.Gitlab.from_config a classmethod #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2019
Merged

Make gitlab.Gitlab.from_config a classmethod #738

merged 1 commit into from
Mar 7, 2019

Conversation

jeroendecroos
Copy link
Contributor

When calling from_config on a subclass of gitlab.Gitlab, a gitlab.Gitlab instance was returned, not the subclass.

I've changed the from_config method to a classmethod, so to return the proper class when called.

I've also added 2 tests to test "from_config".

gpocentek
gpocentek approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@gpocentek gpocentek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@gpocentek gpocentek merged commit 6bd1902 into python-gitlab:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gpocentek gpocentek gpocentek approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeroendecroos @gpocentek