Skip to content

Custom cli actions fix #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2019
Merged

Custom cli actions fix #760

merged 2 commits into from
May 10, 2019

Conversation

kkoralsky
Copy link
Contributor

run into 2 cli custom actions related issues while wokring on #759

  • *Manager custom actions (in_obj=False) ask for managed object id for example:
    • $ gitlab project-key enable --help or
    • $ gitlab runner all --help
  • *Manager custom actions (in_obj=False) dont get -/_ method name replaced

@max-wittig
Copy link
Member

Thanks for the contribution. What do you mean with ask for managed object id for example:. I've tested your changes against master and don't see any difference in CLI output.

@kkoralsky
Copy link
Contributor Author

Basically for the first example action (gitlab project-key enable), cli would require --id and --key-id mandatory flags,

(ansdev3) koral@x270 ~/w/python-gitlab ±master⚡ » gitlab project-key enable --help
usage: gitlab project-key enable [-h] --project-id PROJECT_ID [--sudo SUDO]
                                 --id ID --key-id KEY_ID

optional arguments:
  -h, --help            show this help message and exit
  --project-id PROJECT_ID
  --sudo SUDO
  --id ID
  --key-id KEY_ID

I doubled checked if I did push all changes here is output on my branch:

(ansdev3) koral@x270 ~/w/python-gitlab ±custom_cli_actions_fix⚡ » gitlab project-key enable --help
usage: gitlab project-key enable [-h] --project-id PROJECT_ID [--sudo SUDO]
                                 --key-id KEY_ID

optional arguments:
  -h, --help            show this help message and exit
  --project-id PROJECT_ID
  --sudo SUDO
  --key-id KEY_ID

@kkoralsky kkoralsky mentioned this pull request May 2, 2019
Merged
@max-wittig max-wittig merged commit e8823e9 into python-gitlab:master May 10, 2019
@max-wittig max-wittig mentioned this pull request May 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkoralsky @max-wittig