Skip to content

refactor: format everything black #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2019
Merged

refactor: format everything black #775

merged 1 commit into from
May 16, 2019

Conversation

max-wittig
Copy link
Member

Black seems to become the defacto standard for python formatting.

A lot of projects are using it already: https://github.com/python/black#used-by

Fixes #772

gpocentek
gpocentek reviewed May 14, 2019
View reviewed changes
Copy link
Contributor

@gpocentek gpocentek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like something's broken, the file creation test is failing.

@max-wittig
Copy link
Member Author

Yes. That's because of my merge in another merge request. See my revert of it. Then I need to rebase this.

@max-wittig
Copy link
Member Author

#776

@max-wittig max-wittig force-pushed the refactor/black branch 2 times, most recently from edf4adb to 18f55ea Compare May 16, 2019 16:00
@max-wittig
Copy link
Member Author

@gpocentek Pipeline passed now.

@gpocentek gpocentek merged commit 290e5ed into master May 16, 2019
@gpocentek
Copy link
Contributor

👍

@max-wittig max-wittig deleted the refactor/black branch May 16, 2019 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpocentek gpocentek gpocentek approved these changes

Assignees

@gpocentek gpocentek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to black for code formatting
2 participants
@max-wittig @gpocentek