Skip to content

Resolve #822, add mr rebase #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2019
Merged

Conversation

jeroen92
Copy link
Contributor

Hi all. This MR adds the rebase method for an MR. Also adds an example in the documentation.

@max-wittig
Copy link
Member

Thanks for this cool contribution. Could you also add tests to it? (I'm sorry that they fail in the CI)

@jeroen92
Copy link
Contributor Author

I've added the rebase to the e2e test. I'm a bit hesitant to add checking the mr.rebase_in_progress as it would introduce a race condition. When the rebase is complete the rebase_in_progress property will be reset back to False.

@max-wittig
Copy link
Member

Okay then we leave them out. I will run the tests manually tomorrow and merge, if they succeed.

@max-wittig max-wittig merged commit b9877b4 into python-gitlab:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants