Skip to content

Add support for job token #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2019
Merged

Add support for job token #876

merged 1 commit into from
Sep 6, 2019

Conversation

sathieu
Copy link
Contributor

@sathieu sathieu commented Sep 5, 2019

@sathieu sathieu force-pushed the job_token branch 2 times, most recently from 86295ca to 91fe5dc Compare September 5, 2019 08:55
max-wittig
max-wittig reviewed Sep 5, 2019
View reviewed changes
Copy link
Member

@max-wittig max-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍

Could we just add some more tests and docs for this feature?

@sathieu sathieu force-pushed the job_token branch 2 times, most recently from ef12fd4 to a8439c1 Compare September 5, 2019 12:55
@sathieu
Copy link
Contributor Author

sathieu commented Sep 5, 2019

@max-wittig All done. Please merge.

max-wittig
max-wittig requested changes Sep 6, 2019
View reviewed changes
Copy link
Member

@max-wittig max-wittig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost looks good! Just one small change

@sathieu sathieu requested a review from max-wittig September 6, 2019 11:43
@max-wittig max-wittig merged commit 8474829 into python-gitlab:master Sep 6, 2019
@sathieu
Copy link
Contributor Author

sathieu commented Sep 9, 2019

Thanks

jalr added a commit to jalr/python-gitlab that referenced this pull request Oct 7, 2019
@jalr
Fix constructing Gitlab object without authentication
a605589 
unauthenticated access is broken since python-gitlab#876 was merged
@jalr jalr mentioned this pull request Oct 7, 2019
Closed
jalr added a commit to jalr/python-gitlab that referenced this pull request Oct 7, 2019
@jalr
fix: constructing Gitlab object without authentication
19feb1e 
unauthenticated access is broken since python-gitlab#876 was merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-wittig max-wittig Awaiting requested review from max-wittig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sathieu @max-wittig