Adding new ProjectHook attributes:
#89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `build_events` * `enable_ssl_verification` See the two links below: * https://github.com/gitlabhq/gitlabhq/blob/master/doc/api/projects.md#add-project-hook * pyapi-gitlab/pyapi-gitlab#173
d0c-s4vage
pushed a commit
to ExodusIntelligence/python-gitlab
that referenced
this pull request
Feb 4, 2016
two separate strings on different lines into one string. see python-gitlab#89 will try to rebase pull request to include this.
|
lol build failed b/c: hrmm |
| @@ -851,7 +851,8 @@ class ProjectHook(GitlabObject): | |||
| requiredUrlAttrs = ['project_id'] | |||
| requiredCreateAttrs = ['url'] | |||
| optionalCreateAttrs = ['push_events', 'issues_events', | |||
| 'merge_requests_events', 'tag_push_events'] | |||
| 'merge_requests_events', 'tag_push_events', | |||
| 'build_events', 'enable_ssl_verification'] | |||
There was a problem hiding this comment.
I don't see build_events in the doc. I see note_events though.
There was a problem hiding this comment.
d0c-s4vage
pushed a commit
to ExodusIntelligence/python-gitlab
that referenced
this pull request
Feb 4, 2016
two separate strings on different lines into one string see python-gitlab#89 will try to rebase pull request to include this
|
hhhhhhhhh ok, I'll reword that commit again. Never knew there were such stringent restrictions on commit messages. |
|
I probably should ignore the commit message check, I agree it's a bit annoying. |
gpocentek
pushed a commit
that referenced
this pull request
Feb 6, 2016
Adding new `ProjectHook` attributes:
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_eventsenable_ssl_verificationSee the two links below: