Remove unused code and simplify string format. #892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-wittig
reviewed
Oct 4, 2019
gitlab/tests/test_base.py
Outdated
| @@ -93,7 +90,6 @@ def test_pickability(self): | |||
| self.assertIsInstance(unpickled, FakeObject) | |||
| self.assertTrue(hasattr(unpickled, "_module")) | |||
| self.assertEqual(unpickled._module, original_obj_module) | |||
| pickled2 = pickle.dumps(unpickled) | |||
There was a problem hiding this comment.
I think this is supposed to be a pickle object test.
There was a problem hiding this comment.
Ok, I will rollback it. :)
|
Thanks for the merge request! Could you just please follow our commit conventions and formulate the commit message like so:
|
Your commit messages are the reason why the tests are failing. More info: https://github.com/python-gitlab/python-gitlab#contributing |
b915dc5 to
c7ff676
Compare
|
@godaji Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked the code and it was pretty clean. I found and fixed some minor improvements. Please reflect if you wish.