improve functionnal tests #896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jouve
commented
Oct 6, 2019
•
- add a new flag -k to reuse the container
- adapt python_test_v4 to be run multiple times
- add reset_gitlab.py to undo changes made by python_test_v4
- use gitlab container from gitlab
- new check when gitlab is started (instead of long sleep)
- simplify generate_token.py with requests-html
|
Thank you very much @jouve. I've always wanted to improve the tests and use the GitLab container. You may need to wait a while longer or use the healthcheck-endpoint so you can be sure that GitLab started completely. |
|
I tried the healthcheck, unfortunatelly it works on my computer by not with travis :( so I had to put the sleep 200 again |
|
Yeah travis is frustrating :( |
|
@jouve Thanks again! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.