Fix constructing Gitlab object without authentication #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Totally missed that. Thanks for the PR. Would you mind to use the commit conventions? So change to commit message to something like: Thank you! |
unauthenticated access is broken since python-gitlab#876 was merged
a605589 to
19feb1e
Compare
|
No worries, sometimes it happens that you overlook something. I just noticed the issue today because my chat bot wasn't working anymore 😄 |
max-wittig
reviewed
Oct 7, 2019
| @@ -355,7 +355,7 @@ def _set_auth_info(self): | |||
| bool(arg) | |||
| for arg in [self.private_token, self.oauth_token, self.job_token] | |||
| ) | |||
| != 1 | |||
| > 1 | |||
There was a problem hiding this comment.
But this does exactly the reverse. It only works, if we have multiple parameters.
We should only check this condition, if the items are larger than 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unauthenticated access is broken since #876 was merged
fixes getting the error
Only one of private_token, oauth_token or job_token should be definedwhen using no authentication method at all.