Skip to content

chore(dist): add test data #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2019
Merged

chore(dist): add test data #916

merged 1 commit into from
Oct 22, 2019

Conversation

bufferoverflow
Copy link
Member

Closes #907

@max-wittig
Copy link
Member

Did you test this? I think we are already in the gitlab dir.

@bufferoverflow
Copy link
Member Author 

$ python3 setup.py sdist bdist_wheel
$ tar -tvzf dist/python-gitlab-1.12.1.tar.gz | grep json
-rw-r--r--  0 meierro staff    2615 Oct 17 11:05 python-gitlab-1.12.1/gitlab/tests/data/todo.json

@bufferoverflow
Copy link
Member Author

@max-wittig I just figured out that the file is not within whl and egg file, I'm unsure if it should be there or not.

@max-wittig
Copy link
Member

@bufferoverflow Thanks for the MR!

@max-wittig max-wittig merged commit e790b1e into master Oct 22, 2019
@bufferoverflow bufferoverflow deleted the chore/add-test-to-dist branch October 22, 2019 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@max-wittig max-wittig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.12.1 pypi dist file doesn't include gitlab/tests/json.data
2 participants
@bufferoverflow @max-wittig