Skip to content

Conversation

SVLay
Copy link

@SVLay SVLay commented Oct 31, 2019

Add a little explanation, for the pipeline variables logic.

@max-wittig
Copy link
Member

The change looks good to me. Could you please rebase to latest master and change our your commit message to match our contribution guidelines?

E.g. docs(builds): add pipeline custom variables usage example

@SVLay
Copy link
Author

SVLay commented Oct 31, 2019

The change looks good to me. Could you please rebase to latest master and change our your commit message to match our contribution guidelines?

E.g. docs(builds): add pipeline custom variables usage example

Sure, will do

@SVLay
Copy link
Author

SVLay commented Oct 31, 2019

Created a new PR for that - #929

@SVLay SVLay closed this Oct 31, 2019
@max-wittig
Copy link
Member

@SVLay Hint: You wouldn't need a new merge request. You can just amend the commit message and force push to your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants