Skip to content

#942: fix up path computation for project-fork list #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2019

Conversation

choyrim
Copy link
Contributor

@choyrim choyrim commented Nov 20, 2019

fix for #942 - path computation wasn't working.

@choyrim choyrim force-pushed the 942-project-fork-list-404 branch from d89600d to 44a7c27 Compare November 20, 2019 05:23
@max-wittig
Copy link
Member

@choyrim But don't you delete the list method here and replace it with the create method?

@choyrim
Copy link
Contributor Author

choyrim commented Nov 20, 2019

@choyrim But don't you delete the list method here and replace it with the create method?

@max-wittig yes that is the end result. I originally just tried to fix the list method but that caused the create to fail. So I noticed that the ProjectPipelineManager had resolved a similar path plurality (pipeline vs pipelines) issue and imitated the approach.

@max-wittig
Copy link
Member

max-wittig commented Nov 20, 2019

Ah I see. Makes sense! Thank you! Just a small comment

@max-wittig max-wittig merged commit ecad2c8 into python-gitlab:master Nov 20, 2019
@choyrim choyrim deleted the 942-project-fork-list-404 branch November 20, 2019 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants