Skip to content

Make numba able to be optional #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eriknw opened this issue Mar 25, 2023 · 1 comment · Fixed by #423
Closed

Make numba able to be optional #415

eriknw opened this issue Mar 25, 2023 · 1 comment · Fixed by #423
Labels
enhancement Improve existing functionality or make things work better

Comments

@eriknw
Copy link
Member

eriknw commented Mar 25, 2023

The primary reason for this is to support other backends that don't use numba.

It is also valid to use SuiteSparse:GraphBLAS with limited functionality without numba. Other advantages of not requiring numba:

I think it's still TBD how we'll support multiple backends and how packages and dependencies will be installed.

Acceptance for closing this issue as complete will be to run tests in CI w/o numba installed and to have good error messages when trying to use features that require numba. Numba may still be listed as a required dependency.

@eriknw eriknw added the enhancement Improve existing functionality or make things work better label Mar 25, 2023
@eriknw
Copy link
Member Author

eriknw commented Mar 29, 2023

We discussed this today during our weekly call.

A possible way forward is to add e.g. "suitesparse-udt" backend that uses numba (and can be the default), and "suitesparse" backend won't use numba.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or make things work better
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant