[EXPERIMENTAL] Add "onchange" hook #262
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PoC to see how invasive it is to add "onchange" hooks.
There may be two uses for this from
graphblas-algorithms
:A
to the user.Overall, I'd say this isn't very invasive all things considered. The number of places hooks are in each file is:
This hook system is pretty simple for now. It only has one hook,
"onchange"
, and it only passes the object that would be changed to the function. Other hooks and arguments to pass to the callbacks are possible (hence our use of**kwargs
in the callback for future compatibility). This also doesn't try to manage having multiple callbacks, which is fine for our current use cases where the objects with hooks will be managed bygraphblas-algorithms
.We may want to add a simple API to manage hooks such as
_add_hook
,_has_hook
,_call_hook
, etc. to make it easier to evolve.We can let this stew for a bit.