Skip to content

include conftest.py in MANIFEST.in #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 6, 2023
Merged

include conftest.py in MANIFEST.in #451

merged 4 commits into from
May 6, 2023

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented May 5, 2023

We somehow forgot to include this. Still need to verify that including this allows us to run tests with custom options, but I think it should.

@eriknw eriknw added hygiene Improve code quality and reduce maintenance overhead tests Unit tests and/or continuous integration labels May 5, 2023
@coveralls
Copy link

coveralls commented May 5, 2023 •
edited
Loading

Coverage Status

Coverage: 98.99% (-0.5%) from 99.54% when pulling 756dc68 on eriknw:include_conftest into 0eeebfc on python-graphblas:main.

@eriknw
Copy link
Member Author

eriknw commented May 5, 2023

Okay, so adding conftest.py to MANIFEST.in actually doesn't add it to the wheel--it's only added to the source distribution. It belongs in the source distribution, so this change is still good.

I just added some logic so that slow tests will run (and not emit warnings) when run via pytest --pyargs graphblas. It also runs "randomly". I don't know how to allow custom cli arguments to be passed in when pytest is invoked in this way.

@eriknw eriknw merged commit f140f9c into python-graphblas:main May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hygiene Improve code quality and reduce maintenance overhead tests Unit tests and/or continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eriknw @coveralls