Skip to content

Allow __index__ only for integral dtypes on Scalars #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2023
Merged

Allow __index__ only for integral dtypes on Scalars #481

merged 1 commit into from
Jul 26, 2023

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Jul 14, 2023

I noticed Scalar.__index__ wasn't quite correct. It should be strict and not work for float dtypes.

Also, update how we check whether inputs are integral or not.

Also, update versions.

@coveralls
Copy link

coveralls commented Jul 14, 2023 •
edited
Loading

Coverage Status

Changes unknown
when pulling aba6999 on eriknw:index
into ** on python-graphblas:main**.

@eriknw eriknw mentioned this pull request Jul 16, 2023
Merged
@eriknw eriknw merged commit 3476731 into python-graphblas:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eriknw @coveralls