Skip to content

Removed deprecated draw #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2023
Merged

Removed deprecated draw #485

merged 1 commit into from
Jul 26, 2023

Conversation

paul-tqh-nguyen
Copy link
Contributor

No description provided.

@eriknw
Copy link
Member

eriknw commented Jul 22, 2023

Thanks @paul-tqh-nguyen, welcome as a contributor!

Oh, looks like we did miss a usage of gb.io.draw in the docs. docs/api_reference/io.rst uses graphblas.io.draw. Maybe change that to graphblas.viz.draw or just remove it. Visualization probably deserves its own page.

@coveralls
Copy link

coveralls commented Jul 22, 2023 •
edited
Loading

Coverage Status

coverage: 99.376% (+0.3%) from 99.107% when pulling 46209e8 on paul-tqh-nguyen:paulnguyen/rm_deprecated_0 into 8bd80f6 on python-graphblas:main.

@paul-tqh-nguyen paul-tqh-nguyen force-pushed the paulnguyen/rm_deprecated_0 branch from 095388d to 46209e8 Compare July 26, 2023 14:07
@paul-tqh-nguyen
Copy link
Contributor Author

I made the minimal change needed to pass CI. I think making a dedicated viz page would make sense, but it probably out of the scope of this PR.

@eriknw
Copy link
Member

eriknw commented Jul 26, 2023

LGTM, thanks @paul-tqh-nguyen--welcome as a contributor!

@eriknw eriknw merged commit ae0366a into python-graphblas:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paul-tqh-nguyen @eriknw @coveralls