Skip to content

dropping support for python3.8 #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

Transurgeon
Copy link
Contributor

Made changes to dependencies, pyproject.toml and CI workflows according to the instructions listed on the wiki.
However, I wasn't sure what to change for this particular instruction:
- Update minimum dependency versions to match what we test
Removing support of a Python version is a natural time to remove supported versions of dependencies, which we may support for much longer than 24 months if it's trivial to do so.

@eriknw
Copy link
Member

eriknw commented Aug 9, 2023

Thanks @Transurgeon! Welcome as a contributor 🎉

These changes look perfect to me to drop Python 3.8 👍

For reference, NEP 29 dropped Python 3.8 support in April this year, and SPEC 0 dropped it about a year ago:

However, I wasn't sure what to change for this particular instruction:

Update minimum dependency versions to match what we test

Aha, it means to update the minimum dependency versions in pyproject.toml if removing Python 3.8 from CI means that we no longer test some versions of dependencies. We still test the same versions of dependencies as we did when we tested with Python 3.8, so no changes are necessary this time.

I will update the instructions on the wiki to mention pyproject.toml, b/c I agree that wasn't clear. Thanks for the feedback.

Removing support of a Python version is a natural time to remove supported versions of dependencies, which we may support for much longer than 24 months if it's trivial to do so.

This means that if we want to, we can also change what versions of dependencies we support. This is completely optional, and I don't want to think about it right now, so let's do nothing :)

Merging!

@eriknw eriknw merged commit 9e1a390 into python-graphblas:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants