Skip to content

Try using sysconfig to configure the SS JIT #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Oct 19, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #515 (72d6154) into main (228faa1) will decrease coverage by 61.69%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##             main     #515       +/-   ##
===========================================
- Coverage   91.65%   29.96%   -61.69%     
===========================================
  Files          95       95               
  Lines       21254    21265       +11     
  Branches     3987     3990        +3     
===========================================
- Hits        19480     6373    -13107     
- Misses       1584    14499    +12915     
- Partials      190      393      +203     

@eriknw eriknw marked this pull request as draft October 19, 2023 02:16
@eriknw
Copy link
Member Author

eriknw commented Oct 19, 2023

Lessons learned:

  • Using sysconfig to provide defaults appears to "just work" for Ubuntu and Mac
    • It also appears to mostly work on Windows except when using python-suitesparse-graphblas wheels (which may not play nicely with conda-forge)
  • pandas 2.1 and numpy 1.21 can't be installed together (note to myself)

So, using sysconfig seem like sane defaults to me (much more sane than using build-time info). How should we set this for Python users? Should we set this by default in python-suitesparse-graphblas, and, if so, should we save the original config and make it easy to restore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant