Handle dtypes (esp. UDTs) better in ewise_union #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 98.96% 99.59% +0.62%
==========================================
Files 95 95
Lines 21254 21291 +37
Branches 3987 3999 +12
==========================================
+ Hits 21035 21205 +170
+ Misses 153 56 -97
+ Partials 66 30 -36 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first introduced these improvements in #501, but I'm splitting them into a new PR b/c they should go into main, and it will make it easier to review (and revert if necessary) #501.
I plan on merging once CI passes. I don't think there's anything particularly controversial or dangerous here, but I'll be happy to answer any questions even after merging.