Skip to content

Add 9.4.5.0 to tests #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Add 9.4.5.0 to tests #557

merged 1 commit into from
Feb 26, 2025

Conversation

jim22k
Copy link
Member

@jim22k jim22k commented Feb 26, 2025

No description provided.

@jim22k jim22k requested a review from eriknw February 26, 2025 15:30
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.40%. Comparing base (522b696) to head (bf9776c).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
+ Coverage   99.13%   99.40%   +0.26%     
==========================================
  Files          93       93              
  Lines       21855    21941      +86     
  Branches     4130     2672    -1458     
==========================================
+ Hits        21667    21810     +143     
+ Misses        121       98      -23     
+ Partials       67       33      -34     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@eriknw eriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jim22k, looks great! I ran CI twice for sanity.

#546 made these branches of setting psgver a bit more clear by doing each Python version and source or upstream, but it does add some duplication and additional effort to add new versions. Hopefully it's not too bad. Simple is probably better than fancy here if we look at it every 6-12 months.

@eriknw eriknw merged commit 22d42f6 into python-graphblas:main Feb 26, 2025
16 checks passed
@eriknw
Copy link
Member

eriknw commented Feb 26, 2025

Also worth noting that we don't need a new release to update metadata since the latest release uses this constraint:

suitesparse = ["suitesparse-graphblas >=7.4.0.0, <10"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants