This repository was archived by the owner on Jan 13, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 196
HTTP20Adapter doesn't convert headers from bytes
to str
ings
#324
Comments
bytes
to str
ings
KOLANICH
added a commit
to KOLANICH-libs/pywikibot-core
that referenced
this issue
May 17, 2017
…ry](python-hyper/hyper#324)) support for HTTP/2.0
KOLANICH
added a commit
to KOLANICH-libs/pywikibot-core
that referenced
this issue
May 17, 2017
…ry](python-hyper/hyper#324)) support for HTTP/2.0
No, this is a newer problem that was introduced because we weren't paying enough attention. It should be a simple fix: simply pass the appropriate encoding argument to the HTTP2 connection class. |
Ah, hang on, that's not it. The HTTP/1.1 stack appears to always provide bytes headers, which may be the actual problem here. We can probably just fix that, but it'll be a breaking change which I'm reluctant to just leap into. I'd rather fix it along with removing our custom parser in favor of h11. |
bytes
to str
ingsbytes
to str
ings
KOLANICH
added a commit
to KOLANICH-libs/hyper
that referenced
this issue
Jul 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Uh oh!
There was an error while loading. Please reload this page.
HTTP20Adapter doesn't convert headers and their keys from
bytes
tostr
ings. It breaks compatibility withrequests
where headers labels arestr
ings. Is this by design?The text was updated successfully, but these errors were encountered: