Skip to content

Add support for setting the timezone #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jimmyson opened this issue Feb 22, 2023 · 4 comments · Fixed by #1157 · May be fixed by #501
Closed

Add support for setting the timezone #436

Jimmyson opened this issue Feb 22, 2023 · 4 comments · Fixed by #1157 · May be fixed by #501
Labels
enhancement New feature or request

Comments

@Jimmyson
Copy link

I recently acquired a set of KP115(AU) units to setup for power monitoring, and have them integrated into my Home Assistant Setup. Used python-kasa to pair them to the network on a separate device. Devices were automatically set to a timezone value of 6, corresponding to US Pacific Time which is outside of my location.

As Home Assistant is polling data from the Units to be logged, and the charts are reporting around 19 hours of Zero data.
The data begins to be captured when the Device clock is on Midnight, and the dates match between the Devices, and the Server.

Screenshot_2023-02-22_16-39-06
image

The current way to adjust the Timezone of the Kasa Devices is to use the official TP-Link app. At present, the python application can only fetch the Timezone data, as stated in the following Terminal Output

$ kasa time | grep Time: && date
	Time:         2023-02-21 21:50:56 (tz: {'index': 6, 'err_code': 0}
	Time:         2023-02-21 21:50:56 (tz: {'index': 6, 'err_code': 0}
	Time:         2023-02-21 21:50:55 (tz: {'index': 6, 'err_code': 0}
Wed 22 Feb 2023 16:50:59 AEDT

Can it be possible to adjust and save Timezone configuration changes to the Kasa devices using the API?

@rytilahti
Copy link
Member

This is not currently implemented, but PRs to add it to the time module (https://github.com/python-kasa/python-kasa/blob/master/kasa/modules/time.py) are welcome.

For the time being, you could use a raw command. The link below mentions that it's necessary to provide current time information but you could start testing with something like this:

kasa raw-command time set_timezone '{"index": 1}'

See https://github.com/GadgetReactor/pyHS100/pull/55/files for the command and GadgetReactor/pyHS100#53 (comment) for a list of index-tz mapping.

@rytilahti rytilahti added the enhancement New feature or request label Feb 22, 2023
@rytilahti rytilahti changed the title [Feature Request] Setting Timezones Add support for setting the timezone Feb 22, 2023
@Jimmyson
Copy link
Author

This is not currently implemented, but PRs to add it to the time module (https://github.com/python-kasa/python-kasa/blob/master/kasa/modules/time.py) are welcome.

For the time being, you could use a raw command. The link below mentions that it's necessary to provide current time information but you could start testing with something like this:

kasa raw-command time set_timezone '{"index": 1}'

See https://github.com/GadgetReactor/pyHS100/pull/55/files for the command and GadgetReactor/pyHS100#53 (comment) for a list of index-tz mapping.

Thanks for the information!!
The raw-command helped. Since I have a couple of devices on the network, I had to individually run the command for each device, but the time is now for updated.

Copy link

There hasn't been any activity on this issue recently. This issue has been automatically marked as stale because of that. It will be closed if no further activity occurs.
Please make sure to update to the latest python-kasa version and check if that solves the issue.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 28, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2024
@rytilahti rytilahti reopened this Oct 6, 2024
@rytilahti
Copy link
Member

Reopened as #1147 aims to add support for this.

@github-actions github-actions bot removed the stale label Oct 7, 2024
@sdb9696 sdb9696 mentioned this issue Oct 29, 2024
sdb9696 added a commit that referenced this issue Oct 29, 2024
## [0.7.6](https://github.com/python-kasa/python-kasa/tree/0.7.6) (2024-10-29)

[Full Changelog](0.7.5...0.7.6)

**Release summary:**

- Experimental support for Tapo cameras and the Tapo H200 hub which uses the same protocol.
- Better timestamp support across all devices.
- Support for new devices P304M, S200D and S200B (see README.md for note on the S200 support).
- Various other fixes and minor features.

**Implemented enhancements:**

- Add support for setting the timezone [\#436](#436)
- Add stream\_rtsp\_url to camera module [\#1197](#1197) (@sdb9696)
- Try default logon credentials in SslAesTransport [\#1195](#1195) (@sdb9696)
- Allow enabling experimental devices from environment variable [\#1194](#1194) (@sdb9696)
- Add core device, child and camera modules to smartcamera [\#1193](#1193) (@sdb9696)
- Fallback to get\_current\_power if get\_energy\_usage does not provide current\_power [\#1186](#1186) (@Fulch36)
- Add https parameter to device class factory [\#1184](#1184) (@sdb9696)
- Add discovery list command to cli [\#1183](#1183) (@sdb9696)
- Add Time module to SmartCamera devices [\#1182](#1182) (@sdb9696)
- Add try\_connect\_all to allow initialisation without udp broadcast [\#1171](#1171) (@sdb9696)
- Update dump\_devinfo for smart camera protocol [\#1169](#1169) (@sdb9696)
- Enable newer encrypted discovery protocol [\#1168](#1168) (@sdb9696)
- Initial TapoCamera support [\#1165](#1165) (@sdb9696)
- Add waterleak alert timestamp [\#1162](#1162) (@rytilahti)
- Create common Time module and add time set cli command [\#1157](#1157) (@sdb9696)

**Fixed bugs:**

- Only send 20002 discovery request with key included [\#1207](#1207) (@sdb9696)
- Fix SslAesTransport default login and add tests [\#1202](#1202) (@sdb9696)
- Fix device\_config serialisation of https value [\#1196](#1196) (@sdb9696)

**Added support for devices:**

- Add S200B\(EU\) fw 1.11.0 fixture [\#1205](#1205) (@sdb9696)
- Add TC65 fixture [\#1200](#1200) (@rytilahti)
- Add P304M\(UK\) test fixture [\#1185](#1185) (@Fulch36)
- Add H200 experimental fixture [\#1180](#1180) (@sdb9696)
- Add S200D button fixtures [\#1161](#1161) (@rytilahti)

**Project maintenance:**

- Fix mypy errors in parse_pcap_klap [\#1214](#1214) (@sdb9696)
- Make HSV NamedTuple creation more efficient [\#1211](#1211) (@sdb9696)
- dump\_devinfo: query get\_current\_brt for iot dimmers [\#1209](#1209) (@rytilahti)
- Add trigger\_logs and double\_click to dump\_devinfo helper [\#1208](#1208) (@sdb9696)
- Fix smartcamera childdevice module [\#1206](#1206) (@sdb9696)
- Add H200\(EU\) fw 1.3.2 fixture [\#1204](#1204) (@sdb9696)
- Do not pass None as timeout to http requests [\#1203](#1203) (@sdb9696)
- Update SMART test framework to use fake child protocols [\#1199](#1199) (@sdb9696)
- Allow passing an aiohttp client session during discover try\_connect\_all [\#1198](#1198) (@sdb9696)
- Add test framework for smartcamera [\#1192](#1192) (@sdb9696)
- Rename experimental fixtures folder to smartcamera [\#1191](#1191) (@sdb9696)
- Combine smartcamera error codes into SmartErrorCode [\#1190](#1190) (@sdb9696)
- Allow deriving from SmartModule without being registered [\#1189](#1189) (@sdb9696)
- Improve supported module checks for hub children [\#1188](#1188) (@sdb9696)
- Update smartcamera to support single get/set/do requests [\#1187](#1187) (@sdb9696)
- Add S200B\(US\) fw 1.12.0 fixture [\#1181](#1181) (@sdb9696)
- Add T110\(US\), T310\(US\) and T315\(US\) sensor fixtures [\#1179](#1179) (@sdb9696)
- Enforce EOLs for \*.rst and \*.md [\#1178](#1178) (@rytilahti)
- Convert fixtures to use unix newlines [\#1177](#1177) (@rytilahti)
- Add motion sensor to known categories [\#1176](#1176) (@rytilahti)
- Drop urllib3 dependency and create ssl context in executor thread [\#1175](#1175) (@sdb9696)
- Expose smart child device map as a class constant [\#1173](#1173) (@sdb9696)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants