Skip to content

Need to be able to both close and reset transports #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sdb9696 opened this issue Jan 22, 2024 · 1 comment
Closed

Need to be able to both close and reset transports #671

sdb9696 opened this issue Jan 22, 2024 · 1 comment
Milestone
0.6.2

Comments

@sdb9696
Copy link
Collaborator

sdb9696 commented Jan 22, 2024

reset should be calleable on error instead of close and the transport can decide whether it needs to close it's underlying http or asyncio connection. However a close should ensure the underlying aiottp.ClientSession is closed to prevent asyncio:Unclosed Client Session errors.
@sdb9696 sdb9696 added this to the 0.6.1 milestone Jan 22, 2024
@rytilahti rytilahti modified the milestones: 0.6.2, 0.6.3 Jan 29, 2024
@sdb9696 sdb9696 modified the milestones: 0.6.3, 0.6.2 Feb 1, 2024
@sdb9696
Copy link
Collaborator Author

sdb9696 commented Feb 1, 2024

Closed with #689

@sdb9696 sdb9696 closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.2
Development

No branches or pull requests
2 participants
@rytilahti @sdb9696