-
-
Notifications
You must be signed in to change notification settings - Fork 221
Improve timezone support #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
As we’ve persevered with py3.8 for so long I think we might as well stick out the next 3 months or so. However rather than installing the back port we could just check the python version in the cli / time module and warn / use utc respectively. |
If we want to have support for timezoned datetimes throughout the library (e.g., to get on_since right for both iot and smart), we need to either use the version from backports or drop 3.8. I'd actually go and drop it already, as that would make a clear cut when the first release of 0.7.0 already depends on the version that is not going to be completely unsupported (https://endoflife.date/python). Also, for pypy, 3.9 and 3.10 are already the only supported versions, so it'd nicely sync with that too. On distributions, Debian is usually considered one of those that lag behind when it comes to new stuff, and their bullseye release, which already shipped 3.9, is also going to be EOL'd very soon. So I don't think we should keep on supporting obsoleted releases just for the sake of supporting them :-) |
Ok fair enough, let's do it! |
Drop support for soon-to-be eol'd python 3.8. This will allow some minor cleanups & makes it easier to add support for timezones. Related to #980 (comment)
on_since
(ref Add timezone to on_since attributes #978) should be adapted to use device-configured timezone--timezone
instead of forcing UTCThe text was updated successfully, but these errors were encountered: