Skip to content

Update light transition module to work with child devices #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

sdb9696
Copy link
Collaborator

@sdb9696 sdb9696 commented Jun 26, 2024

The PR contains a few fixes and improvements for the LightTransition module:

  • Fixes it to work with child devices, i.e. ks240
  • Exposes a features to test for supported and allow getting the maximum values from the module interface
  • Interrogates the data to see whether maximums are available. Now possible with _post_update_hook
  • Fixes a bug whereby setting a duration while the feature is not enabled does not actually enable it.

N.B. the ks240 has component version 2 but does support the maximum values

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 97.95918% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.33%. Comparing base (cf24a94) to head (7638045).
Report is 78 commits behind head on master.

Files with missing lines Patch % Lines
kasa/smart/modules/lighttransition.py 97.87% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
+ Coverage   91.22%   91.33%   +0.11%     
==========================================
  Files          84       84              
  Lines        5638     5657      +19     
  Branches     1374     1371       -3     
==========================================
+ Hits         5143     5167      +24     
+ Misses        384      382       -2     
+ Partials      111      108       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti rytilahti added this to the 0.7.0.2 milestone Jun 26, 2024
@sdb9696 sdb9696 requested a review from rytilahti June 27, 2024 13:35
@sdb9696 sdb9696 requested a review from rytilahti June 27, 2024 16:45
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested to work with v1 L920 and V3 L530!

@sdb9696 sdb9696 added the bug Something isn't working label Jun 27, 2024
@sdb9696 sdb9696 merged commit 2a62849 into master Jun 27, 2024
25 checks passed
@sdb9696 sdb9696 deleted the fix/child_transition branch June 27, 2024 17:52
@sdb9696 sdb9696 mentioned this pull request Jul 1, 2024
sdb9696 added a commit that referenced this pull request Jul 1, 2024
## [0.7.0.2](https://github.com/python-kasa/python-kasa/tree/0.7.0.2) (2024-07-01)

[Full Changelog](0.7.0.1...0.7.0.2)

This patch release fixes some minor issues found out during testing against all new homeassistant platforms.

**Fixed bugs:**

- Disable multi-request on unknown errors [\#1027](#1027) (@sdb9696)
- Disable multi requests on json decode error during multi-request [\#1025](#1025) (@sdb9696)
- Fix changing brightness when effect is active [\#1019](#1019) (@rytilahti)
- Update light transition module to work with child devices [\#1017](#1017) (@sdb9696)
- Handle unknown error codes gracefully [\#1016](#1016) (@rytilahti)

**Project maintenance:**

- Make parent attribute on device consistent across iot and smart [\#1023](#1023) (@sdb9696)
- Cache SmartErrorCode creation [\#1022](#1022) (@bdraco)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants