Skip to content

Fix switching off light strip effects #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

sdb9696
Copy link
Collaborator

@sdb9696 sdb9696 commented Jul 1, 2024

No description provided.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.37%. Comparing base (8af23c8) to head (3e65cfd).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           fix/effect_brightness    #1024      +/-   ##
=========================================================
- Coverage                  91.38%   91.37%   -0.01%     
=========================================================
  Files                         84       84              
  Lines                       5720     5716       -4     
  Branches                    1392     1389       -3     
=========================================================
- Hits                        5227     5223       -4     
  Misses                       383      383              
  Partials                     110      110              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works on L920 and L900, thanks a lot!

@rytilahti rytilahti merged commit 88e3310 into fix/effect_brightness Jul 1, 2024
23 checks passed
@rytilahti rytilahti deleted the fix/effect_off branch July 1, 2024 11:30
@sdb9696 sdb9696 added the bug Something isn't working label Jul 1, 2024
@sdb9696 sdb9696 added this to the 0.7.0.2 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants